Skip to content

Secondary storage: Allow store deletion after successful data migration#4615

Merged
yadvr merged 1 commit into
apache:4.15from
shapeblue:code-revert
Feb 24, 2021
Merged

Secondary storage: Allow store deletion after successful data migration#4615
yadvr merged 1 commit into
apache:4.15from
shapeblue:code-revert

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 commented Jan 25, 2021

Description

This PR fixes the issue reported in :#4613
This issue seems to have cropped up due to code revert that happened by commit - d864e9d

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

  1. Migrate data from one image store to another
  2. Attempt deleting the store from where all data objects we migrated

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Jan 25, 2021

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 25, 2021

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@Pearl1594 Pearl1594 changed the base branch from master to 4.15 January 25, 2021 04:34
@Pearl1594 Pearl1594 added this to the 4.15.1.0 milestone Jan 25, 2021
@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Jan 25, 2021

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 25, 2021

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 25, 2021

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2577

harikrishna-patnala
harikrishna-patnala approved these changes Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland DaanHoogland mentioned this pull request Jan 25, 2021
Closed
shwstppr
shwstppr reviewed Jan 25, 2021
View reviewed changes
Comment thread server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java
@apache apache deleted a comment from blueorangutan Feb 9, 2021
@apache apache deleted a comment from blueorangutan Feb 9, 2021
@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Feb 9, 2021

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 9, 2021

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 9, 2021

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2666

@yadvr yadvr requested a review from shwstppr February 18, 2021 12:52
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 18, 2021

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 18, 2021

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 18, 2021

Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2738

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Feb 22, 2021

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 22, 2021

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@apache apache deleted a comment from blueorangutan Feb 23, 2021
@apache apache deleted a comment from blueorangutan Feb 23, 2021
@apache apache deleted a comment from blueorangutan Feb 23, 2021
@apache apache deleted a comment from blueorangutan Feb 23, 2021
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 23, 2021

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2812

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 23, 2021

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 23, 2021

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 23, 2021

Trillian test result (tid-3604)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33931 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4615-t3604-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr merged commit a896760 into apache:4.15 Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

No one assigned

Labels

component:secondary-storage type:bug

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Pearl1594 @blueorangutan @shwstppr @yadvr @harikrishna-patnala